Remove usage of float keys in arrays tests #6662
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Feb 3, 2021
nikic
approved these changes
Feb 8, 2021
| @@ -2,7 +2,7 @@ | |||
| basic array_fill test | |||
| --FILE-- | |||
| <?php | |||
| $array1 = array(0.0, 1, 2.5); | |||
| $array1 = array(0, 1, 2); | |||
| @@ -1,51 +0,0 @@ | |||
| --TEST-- | |||
| Test array_key_exists() function : usage variations - floats and casting to ints | |||
There was a problem hiding this comment.
I think this one is important to keep -- array_key_exists behavior with floats.
| @@ -46,13 +46,9 @@ $arrays = array ( | |||
| array("1" => 1), | |||
| array("one" => 1, 'two' => 2, "three" => 3, 4 => 4), | |||
|
|
|||
| // arrays with float values | |||
| /*5*/ array("float" => 2.3333), | |||
| array("f1" => 1.2, 'f2' => 3.33, 3 => 4.89999922839999, 'f4' => 33333333.333333), | |||
There was a problem hiding this comment.
Not particularly important, but these two look unrelated? Those are float values only.
There was a problem hiding this comment.
Indeed, don't know why I went and removed those
Also make test output not produce trailling whitespaces
Girgias
force-pushed
the
remove-float-keys-array-test
branch
from
77140b0 to
fbc495d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make test output not produce trailling whitespaces
This is in preparation for #6661 as this would just distract from the other PR, and these tests are rather useless.